[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-143984151 @gregavola, this change has not released yet, so you have to wait for next cordova release. As an option you could try to clone this repository and

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-28 Thread gregavola
Github user gregavola commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-143828977 Sorry to comment here - but how I can update my version of Cordova-Lib to support this change? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-01 Thread m1r4ge
Github user m1r4ge closed the pull request at: https://github.com/apache/cordova-lib/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-01 Thread m1r4ge
Github user m1r4ge commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136740512 Closed. Thank you Vladimir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136734142 his was merged in https://github.com/apache/cordova-lib/commit/b0c196510aa73b3ef0752c78f06e2a99afe04a95. @m1r4ge, could you please close this PR. --- If

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-31 Thread m1r4ge
Github user m1r4ge commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136423739 @vladimir-kotikov It's seemed to me that I tried that method and it didn't work properly. Now everything works fine. Thx for clarifications. I'll file Aache ICLA soo

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-31 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136397624 @m1r4ge, tested and confirm that this works. However, there is already a `nodeEqual` method (see https://github.com/apache/cordova-lib/blob/master/cordova-

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-31 Thread KonradFak
Github user KonradFak commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136372119 +1, waiting for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-31 Thread psychowico
Github user psychowico commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136369156 can you merge this, plz? very annoying bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-18 Thread machty
Github user machty commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-132415681 +1, fixes the issue for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-07-13 Thread m1r4ge
GitHub user m1r4ge opened a pull request: https://github.com/apache/cordova-lib/pull/256 CB-9354 Fix array merging with complex items The issue corresponding to this PR [CB-9354](https://issues.apache.org/jira/browse/CB-9354). You can merge this pull request into a Git repository b