Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user david-barth-canonical commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/349#discussion_r46569876
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,54 @@ function toCamelCase(str) {
}).join('');
}
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/349#issuecomment-161826181
Thanks - LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user david-barth-canonical commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/294#discussion_r46471716
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,51 @@ function toCamelCase(str) {
}).join('');
}
GitHub user david-barth-canonical opened a pull request:
https://github.com/apache/cordova-lib/pull/349
Cb 9590 - Ubuntu support for the new plugin naming convention
Re-opening the pull request with hopefully a better fix that can handle all
situations.
You can merge this pull
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/349#discussion_r46494465
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,54 @@ function toCamelCase(str) {
}).join('');
}
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/294#discussion_r46228904
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,51 @@ function toCamelCase(str) {
}).join('');
}
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user david-barth-canonical commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-153422772
I have update the pull request to add support for taking the class name
from the plugin.xml file. For plugins using one of the 2 existing naming
Github user david-barth-canonical commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-148743166
ok, i understand the problem now. In particular, the code to guess the
classname is nice, but other platforms resort to encapsulating this
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-148444797
@david-barth-canonical - I think @stevengill's point is that the intent of
your change is to strip the `cordova-plugin` from the start of the plugin name
to
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-148109218
I want to merge this in, but it doesn't seem to support plugins that don't
start with cordova-plugin-*. Example, phonegap-plugin-push. Plugins can be
named
Github user david-barth-canonical commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-138310314
It does work both with old style plugin names, like
"org.apache.cordova.battery-status" and new style names
"cordova-plugin-media-capture". I can add
Github user Zaspire commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-137925691
it will not work for third_party plugins (e.g.
com.phonegap.plugins.facebookconnect)
---
If your project is set up for it, you can reply to this email and have
GitHub user david-barth-canonical opened a pull request:
https://github.com/apache/cordova-lib/pull/294
CB-9590 - Ubuntu support for the new plugin naming convention
This patch allows ubuntu users to add plugins using the new naming
convention and build properly. This also leaves
15 matches
Mail list logo
