[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

2015-09-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/295#issuecomment-137353546 Looks good. However there is another chance to access `this._config` before it will be initialized:

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

2015-09-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

2015-09-02 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/295 CB-9604 Fix error adding browser platform with PlatformApi polyfill. Don't try to create `ConfigParser()` in `PlatformApiPoly` constructor, since we may not have copied the `config.xml` file

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

2015-09-02 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/295#issuecomment-137297111 @vladimir-kotikov - does this fix look right to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as