Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-92777120
correct. `restore` command is removed and restoration happens during
`prepare`. You can call `cordova prepare` explicitly to get the similar results
to `restore`.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-92610783
I believe the decision was made not to implement `restore`, since it
happens automatically on `prepare`.
---
If your project is set up for it, you can reply to th
Github user danielcompton commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-92569269
What is the command to run the restore command? I'm using cordova 4.3.0 and
I get this message running restore:
```sh
$cordova restore
Cordova does
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75656828
what about the other options ? (opts).
shouldn't we pass them along to 'prepare' ?
---
If your project is set up for it, you can reply to this email and have you
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75640710
when --save/autosave is on, we should be overriding what's in config.xml,
like we do on the platform side :
https://github.com/apache/cordova-lib/blob/master/cordova
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75615699
you forgot to negate opts.save as well : if(!autosave && !opts.save && ...)
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75574968
Reviewing latest changes ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75547919
I think I have addressed the concerns with the latest. If everyone is cool
with it, we should go ahead and merge them in.
---
If your project is set up for it, you c
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/166#discussion_r24875047
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -136,6 +135,35 @@ module.exports = function plugin(command, targets,
opts) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/166#discussion_r24875027
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -136,6 +135,35 @@ module.exports = function plugin(command, targets,
opts) {
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74318530
What if a plugin install fails ? don't we want to continue with other
plugins' install like we do for platforms ?
That way, we also handle platform-dependent plug
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74313313
hmmm, it seems to me that during prepare, while restoring from config.xml,
we do use variables from config.xml. so, we should save it during
--save/autosave. Please,
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74294685
sure... as long as there plugin install logic uses variables from
config.xml, which does not.
---
If your project is set up for it, you can reply to this email and h
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74293656
Also, we should probably save the plugin variables along with the version
into config.xml, so that on prepare/restore, we don't fail.
---
If your project is set up
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74284189
Save logic is a bit disorganized because I was expecting @omefire to
implement it for plugins as well, so I have whipped up something. I will
probably make another pa
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74155732
When the flag --save/autosave on, we should not be retrieving the version
from config.xml.
For example,
- config.xml contains org.apache.cordova.device@0.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74151973
Hey @gorkem, I notice that --save covers add and remove. Are you going to
send a pull request to handle the update case ? : 'cordova plugin update
org.apache.cordova
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74151061
Hey @gorkem, I notice that --save covers add and remove. Are you going to
send a pull request to handle the update case ? : 'cordova plugin update
org.apache.cordova
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74146324
'saving to config.xml' should happen after the plugin has been installed on
the platforms.
That way, if any error is encountered during the install, the config.x
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74145216
I think the 'saving to config.xml' should be moved into a separate function
and called from here. this function is getting way too long to easily reason
about it.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74143188
if no version is specified for (e.g: cordova plugin add
org.apache.cordova.device --save), we end up saving the current edge version
(org.apache.cordova.device@0.2.1
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74128449
Cool feature list. reviewing this, :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-lib/pull/166
Save/Restore for plugins and platforms
I think this is a good point to merge these features.. It provides most of
the functionality and frankly I am tired of rebasing/merging.
Several f
24 matches
Mail list logo
