Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/127#issuecomment-68810407
Yeah, I agree with Andrew. -1 on this from me.
It is okay if the top level is missing one level of indentation after being
wrapped by plugman install.
---
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/127#issuecomment-68616124
Ah, okay. I think if you're doing this, then you need to manually delete
the function(){} wrapper that cordova adds to the file, no? In which case you
wouldn't want
Github user roadmanfong commented on the pull request:
https://github.com/apache/cordova-lib/pull/127#issuecomment-68133127
Thanks for reply.
When I develop the new plugin, I'll edit files in generated plugins folder.
After everything works fine. I'll copy this contents in wrapp
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/127#issuecomment-67985332
What's the motivation for this? One nice thing about how it currently works
is that the addition of the function() wrapper doesn't change line number, nor
column num
GitHub user waneblade opened a pull request:
https://github.com/apache/cordova-lib/pull/127
indented scriptContent.
Indented plugin JS files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/waneblade/cordova-lib master
Alternativ
