Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122334506
--- Diff: src/util/alias.js ---
@@ -0,0 +1,27 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122330032
--- Diff: src/util/alias.js ---
@@ -0,0 +1,27 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122284211
--- Diff: spec-cordova/platform/index.spec.js ---
@@ -0,0 +1,181 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122233685
--- Diff: spec-cordova/platform/index.spec.js ---
@@ -0,0 +1,181 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r14237
--- Diff: spec-cordova/platform/addHelper.spec.js ---
@@ -0,0 +1,515 @@
+/**
--- End diff --
Sort of. The old tests I `xdescribe`d them
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r13046
--- Diff: src/cordova/platform.js ---
@@ -1,769 +0,0 @@
-/**
--- End diff --
Sure do! Basically, each module should have unit tests. A
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122219931
--- Diff: spec-cordova/platform.spec.ios.js ---
@@ -1,137 +0,0 @@
-/**
--- End diff --
Yes:
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122097628
--- Diff: spec-cordova/platform.spec.ios.js ---
@@ -1,137 +0,0 @@
-/**
--- End diff --
These tests got moved out to cordova-ios?
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122101116
--- Diff: src/cordova/platform.js ---
@@ -1,769 +0,0 @@
-/**
--- End diff --
to confirm, you ripped out this file into multpile
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122097578
--- Diff: spec-cordova/platform/addHelper.spec.js ---
@@ -0,0 +1,515 @@
+/**
--- End diff --
This file is just a placeholder for now
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-lib/pull/562
Removing lazy load, platform command refactor, start of finer-grained unit
tests.
### Platforms affected
all / node ?
### What does this PR do?
A lot!
1.
12 matches
Mail list logo
