Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-179507278
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178801188
@dblotsky I don't think there is an easy way to get the running simulator,
so instead I am going to move the simulator choosing logic from `cordova run`
to medic
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178865169
Yep, that sounds fine. I would even say not to worry about it if you want
to leave it as it is: on the CI environment we have only one simulator/device
anyway.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178919636
Alright I'm going to leave it as is and I'll change it if it becomes an
issue.
---
If your project is set up for it, you can reply to this email and have your
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178139856
@dblotsky I think that medic-log and medic-run are both performed in the
same directory (I got the `getLocaLCLI()` function from medic-run). See [this
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178145536
@dblotsky addressed the synchronous `exec` calls
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178125278
@nikhilkh sorry for the delay, addressing the code review now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/73#discussion_r51514684
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
return;
}
-function logIOS() {
-var
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178318882
I tried this on my machine and I ran into an issue where it couldn't find
the deployed simulator because there were other non-deployed simulators
installed. Is
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/73#discussion_r51514920
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
return;
}
-function logIOS() {
-var
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/73#discussion_r51514960
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
return;
}
-function logIOS() {
-var
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178333571
@dblotsky I'm not sure; I copied `cordova run's logic for choosing the
emulator. This does not support choosing a specific simulator, just the
default. I'll look
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178267393
@riknoll: The value returned by `getLocalCLI()` is used after
`shell.pushd()` is called [here][pushd] to get into the `mobilespec` app
directory in `medic-run`,
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178293314
@dblotsky no problem; we need to be in a cordova project for that command
(`cordova run --list`) to work anyway, so I'll just call `pushd` here as well.
Thanks
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/73#discussion_r51515589
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
return;
}
-function logIOS() {
-var
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178308453
@dblotsky updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178123204
@riknoll What's required to get this merged in? Let's try to get this asap
as without this we don't understand why cordova-ios is failing:
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-176998784
Two things:
1. I think the `medic log` command gets executed outside of the mobilespec
app, so `./cordova` is not available there. This can be fixed though.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-177001181
@riknoll but if we pass a callback, it defaults to `true`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-177008077
The script should still run synchronously even if those calls are async,
but it's still a good idea to clean up that code. @dblotsky how can I determine
what
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-17682
Also:
3. `shelljs.exec` needs `{silent: false, async: false}` to run
synchronously, which it seems like is more fitting for a script.
---
If your project is
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-176999829
@dblotsky I agree that this should be in the platform and I know that there
is a log script there already, but how do you invoke that script from the CLI?
I don't
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-177000279
@riknoll I think for Android it gets called directly, so we can do the same
for iOS for now maybe.
---
If your project is set up for it, you can reply to this
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-177000821
@riknoll But if silent is set to true, can the results be seen in the logs
by build sheriff?
From: Dmitry Blotsky [mailto:notificati...@github.com]
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-177000890
`silent` and `async` both default to false. See
https://github.com/shelljs/shelljs#execcommand--options--callback
---
If your project is set up for it, you can
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-177002066
Alright, I'll change it but logging was async before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-177015645
@riknoll one way is to pass the mobilespec dir. Another is to just assume
that it gets called from the build root.
---
If your project is set up for it, you can
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-medic/pull/73
CB-10474: Fix cordova-ios logging
We were searching for the simulator logs in the wrong place. This fix
attempts to figure out what simulator is running and grab the system logs for
it.
29 matches
Mail list logo
