[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-02-09 Thread spirylics
Github user spirylics commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-181967238 @tripodsan I've made a pullrequest : https://github.com/apache/cordova-osx/pull/30 Is it sufficient ? Since several weeks, I use case sensitive and I h

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-02-09 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-181955368 thanks @spirylics for pointing this out. can you create a new issue in https://issues.apache.org/jira/browse/CB ? --- If your project is set up for it, you can re

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-02-08 Thread spirylics
Github user spirylics commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-181573279 It should be 'JavaScriptCore/JavaScriptCore.h' instead of 'JavascriptCore/JavascriptCore.h'. (uppercase S) It doesn't work with case sensitive file system. -

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-02-08 Thread SahilBh
Github user SahilBh commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-181445940 JavascriptCore is an framework present on mac os just like webkit. See here: http://www.steamclock.com/blog/2013/05/apple-objective-c-javascript-bridge/ --- If you

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-02-06 Thread spirylics
Github user spirylics commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-180792552 Somebody has this issue : ../CDVBridge.m:21:9: fatal error: 'JavascriptCore/JavascriptCore.h' file not found [exec] #import With OSX 10.11.13, co

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-01-07 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-169758462 thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-01-06 Thread sahilrulzs
Github user sahilrulzs commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-169554517 Here you go: https://issues.apache.org/jira/browse/CB-10308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-01-05 Thread sahilrulzs
Github user sahilrulzs commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-169104897 Sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-01-05 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-169104634 thanks for the PR. can you open a proper jira issue and a test case that illustrates the behavior? --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2015-12-21 Thread sahilrulzs
GitHub user sahilrulzs opened a pull request: https://github.com/apache/cordova-osx/pull/29 Support for multi-dimensional js array/objects Previous implementation was not parsing multi-dimensional JS array > object properly. Replacing it with webkit javascriptCore implementation sol