Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-101133525
I believe localization should never be up to the user of the component; the
component itself should handle localization seamlessly.
This is how th
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-101119417
As this is iOS specific, I'm not sure it makes sense as a JavaScript
parameter. Is there any provision for translating strings that are part of the
Cordov
Github user seronal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-101084822
Yes but not everyone uses native localization support. It's much easier to
handle the localization on the javascript side, especially if you are targeting
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-101083680
In the end it's not really hardcoded. If you notice, it is wrapped using
NSLocalizedString. If you have a localized String resource file, it will load
fro
Github user seronal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-101083460
I don't know what is the official stance on this, but I don't think it's a
good idea to hardcode an error message string (i.e. "Access to the camera has
b
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-100305930
Thanks for the PR Dan -- I'm away, will take a look Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-100047309
@shazron Any possibility of a review & merge for the next plugin release?
---
If your project is set up for it, you can reply to this email and have your
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-94880942
@stevengill @shazron Is it possible to get a review on this and some
feedback on whether it is OK to merge?
---
If your project is set up for it, you can
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-82518530
@shazron I just re-merged master and rebased the changes so it's a clean
commit. Any chance of getting this pulled in to the next release?
---
If your pro
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-69861487
I cleaned up the merge conflict, and I believe it's now working again. I
had a bunch of issues upgrading my plugin (CDVCamera.m seemed to drop off the
list
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-69424925
My apologies, the code has been refactored to be testable, so it doesn't
merge cleanly anymore. It should be an easy rebase from your patch (I hope).
---
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/49
CB-7667 iOS8: Handle case where camera is not authorized
In iOS 7+, when the app does not have access to the camera, show a
prompt notifying the user so they're not puzzled by looki
13 matches
Mail list logo
