Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#issuecomment-90455256
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#issuecomment-90293828
@vladimir-kotikov @sgrebnov ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744691
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: fu
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744687
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: fu
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744671
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: fu
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744681
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: fu
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744642
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: fu
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744665
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: fu
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744649
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: fu
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744001
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: fu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27377731
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27377359
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27377356
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27377331
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27377337
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27377348
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27377326
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27377322
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePi
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#issuecomment-87098082
@vladimir-kotikov @sgrebnov Can you please review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/78
CB-8706, CB-8707 saveToPhotoAlbum improvements and some refactoring
- On Windows we should use filePicker instead of programmatically accessing
user libs. This way the app doesnt have
21 matches
Mail list logo
