Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158245865
Agree with above. Otherwise, LGTM. Tested on an 8.1 device (and by tested I
mean I took a picture, not really sure what else to do here). I don't really
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243766
Good suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243037
You could place the value into a constant named `HIGHEST_POSSIBLE_Z_INDEX`,
and then it would be both documented and easier to maintain.
---
If your pr
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-157877274
This is the max value for signed 32 bit integer which the browsers use to
store z-index. If they use anything above this, it's changed to this value.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-157875931
What happens when someone puts something at 2147483648?
My only complaint is the seemingly random magic number use, and the fact
that it 'implie
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-157873674
The button should appear on top of the video element hence we need the
higher z-index value. We can keep the same z-index values same as well since
the
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-157839720
I believe that is to keep the video element behind the buttons.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-157837124
Why 2147483646 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/140
CB:8940 Setting z-index values to maximum for UI buttons
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plug
10 matches
Mail list logo
