Github user charlesverge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-155517946
@infil00p The method comes from a previous version of the plugin which was
working for some devices.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-155520309
@charlesverge Yeah, and it was slated to be "deprecated" for some reason,
which is why I forgot about it. I added it back in since we can't use the
Github user nikmartin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-153958937
On a Samsung S5 with Android 5.0.1 this patch works fine
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-153969952
@charlesverge, do you have an ICLA signed for this? Usually when people
write entire new methods, I need an ICLA before I can accept public
Github user charlesverge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-151165724
@nikopolv Does the Sony Aqua M2 with 4.4 kitkat work with the branch issue
#93 is based off of ?
---
If your project is set up for it, you can
Github user nikopolv commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-149804724
@charlesverge The Sony Aqua M2 had 4.4 kitkat running in it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nikopolv commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-149153237
Still crashing on Sony Aqua M2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user charlesverge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-149220643
@riknoll The code in #93 is missing a null pointer check
But the differences for the code which retrieves the url is
#112
+
Github user charlesverge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-149219346
@nikopolv This fix usually covered pre Kit Kat devices, does #93 execute
properly with your Sony Aqua M2 ? Also, can you indicate the os version you
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-146297576
Is this fixing the same issues as #93?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user devteamshippeo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-145861688
I have the same issue on Samsung J1 this morning
Thanks for this fix !
---
If your project is set up for it, you can reply to this email and
GitHub user charlesverge opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/112
CB-9446 Fix real path returning null pointer on some Samsung devices
Fix for https://issues.apache.org/jira/browse/CB-9446
You can merge this pull request into a Git repository
12 matches
Mail list logo
