Github user riknoll closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154574485
Looks fine, but maybe we should just remove this check and do this another
way.
---
If your project is set up for it, you can reply to this email and
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154568849
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154577011
I was trying to preserve the existing behavior, but I totally agree it's
not ideal. What we lose by doing this check is the filename and EXIF data for
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154577826
I think that's what #112 does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093297
--- Diff: src/android/CameraLauncher.java ---
@@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri
uri) throws
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093710
--- Diff: src/android/CameraLauncher.java ---
@@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri
uri) throws
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/135
CB-9960 android: Fixed FileNotFoundException for some gallery images
Certain gallery applications (such as Google Photos) return `content://`
URIs that our method of getting a file
