Github user mccob commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-216922029
how to invoke permission since Android M permissions system for WebRTC
getUserMedia ?
---
If your project is set up for it, you can reply to this email an
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user SergiiS commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-193183285
Hello guys, was it merged? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-191358763
Hey @okonon, that has been done in #179, which will hopefully be merged in
soon. Just waiting on an ICLA.
---
If your project is set up for it, you can
Github user okonon commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-191237075
Hello all! @ochakov could you please resolve the conflicts so this can be
merged?
Or anyone else?
@riknoll @infil00p @MatthewBooth
As mor
Github user dieppe commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-188872652
You can also check this fork https://github.com/jnuine/cordova-plugin-camera
It includes a major refactor of the iOS plugin which fixes some bugs,
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186312333
@infil00p I've rebased here:
https://github.com/apache/cordova-plugin-camera/pull/174
---
If your project is set up for it, you can reply to this e
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186300094
WTF? I thought this was merged weeks ago, or we decided not to merge it or
something. We need to get the conflicts resolved and this thing pulled in.
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186290675
This should be merged ASAP. It fixes this very issue for a project I'm
working on.
You absolutely should be declaring the permissions in th
Github user ianisted commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181852903
@ochakov thanks, but I'm needing to perform QR code scanning. Seems you
have a similar issue, though the phonegap-plugin-barcodescanner plugin uses
Inte
Github user ochakov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181845807
@ianisted
Use my version of the plugin
https://github.com/ochakov/cordova-plugin-camera
---
If your project is set up for it, you can reply to t
Github user ianisted commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181845462
Any luck with a resolution to this issue? I'm using that Barcode plugin and
I'm getting the following error "Sorry, the Android camera encountered a
pro
Github user ochakov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-172336151
@riknoll, I can't really invest more time in this bug. I am doing
completely different things now.
---
If your project is set up for it, you can reply t
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-171800967
Awesome, thanks for doing that! Would you mind also incorporating the fix I
commented on in the diff?
---
If your project is set up for it, you can repl
Github user ochakov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-168818980
@riknoll done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-168751426
@ochakov any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-162598821
@ochakov thanks for doing that! Can you add your name to your GitHub
profile so that we can verify?
---
If your project is set up for it, you can reply
Github user ochakov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-162259724
ICLA has been filed and approved by Craig L Russell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#discussion_r46596545
--- Diff: src/android/CameraLauncher.java ---
@@ -178,7 +181,7 @@ else if ((this.srcType == PHOTOLIBRARY) ||
(this.srcType == SAVEDPHOTOALBUM)
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161748614
@ochakov I'll do some testing, but this looks pretty good! In the meantime,
can you fill out an Apache ICLA? There are instructions for doing so
[here](h
Github user ochakov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161470590
Added both fixes to this PR
Camera permission will not be required unless android.permission.CAMERA is
set in the package.
BTW, barcode scanner an
Github user ochakov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423854
riknoll,
Sounds alright. I would also check camera and storage permissions
separately in case someone will approve one of them, but deny the other. Ne
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423220
Agreed. But this PR should be updated to check the PackageInfo first.
@ochakov does that sound alright to you?
---
If your project is set up for it, you
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161417898
Right, Barcode Scanner! That thing! So, if there's an app that uses the
Barcode Scanner and takes a picture, then it can cause a problem.
I'm s
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161417577
Here's one that declares it:
https://github.com/phonegap/phonegap-plugin-barcodescanner
---
If your project is set up for it, you can reply to this emai
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416757
I feel like we can easily handle it, though, by programmatically checking
if the permission was declared before we take a picture and only requesting it
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416812
BTW: Do we have a third-party plugin that asks for Camera? And if a
Third-Party plugin is asking for the CAMERA permission, shouldn't they have
their ow
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161415816
@ochakov
1. Yes, it still works, because this relies on the permission of the
Camera, not the permission of the application firing the event.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414891
@riknoll Yeah, but that's a problem that should be in the docs, and not in
this code.
---
If your project is set up for it, you can reply to this emai
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414408
In the developer reference:
http://developer.android.com/reference/android/content/pm/PackageInfo.html#requestedPermissions
---
If your project is set u
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414060
@infil00p if a third party plugin declares the permission in their
plugin.xml so that is inserted into the manifest, then you get a
SecurityException and
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161413648
You do not need the Camera permission for the Camera plugin because we use
intents. Why are we trying to request this permission? That's the recommende
Github user ochakov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161412438
I have two questions then:
1. When you do not declare camera permission in the manifest, does it work
on older Android versions?
2. When you do no
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161410634
BTW, I created a JIRA for this
([CB-10120](https://issues.apache.org/jira/browse/CB-10120))
---
If your project is set up for it, you can reply to this
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161410396
Thanks for submitting a PR! I actually just ran into this issue while
working on [another issue in
JIRA](https://issues.apache.org/jira/browse/CB-10064).
GitHub user ochakov opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/142
Fix missing CAMERA permission for Android M
Fixing a bug where for Android M new permissions model, only external
storage permission was asked, while camera permission was not, causin
36 matches
Mail list logo
