[GitHub] cordova-plugin-camera pull request: StatusBar Hidden Fix

2015-05-15 Thread fretman92
Github user fretman92 commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/37#issuecomment-102335756 +1 for this issue, the plugin should detect the presence of the status bar, and hide it when finished if necessary. --- If your project is set up for i

[GitHub] cordova-plugin-camera pull request: StatusBar Hidden Fix

2015-01-09 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/37#issuecomment-69424984 My apologies, the code has been refactored to be testable, so it doesn't merge cleanly anymore. It should be an easy rebase from your patch (I hope) - and

[GitHub] cordova-plugin-camera pull request: StatusBar Hidden Fix

2014-09-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/37#issuecomment-55659861 This fixes it for your case, but it is inadequate for the other case, where the user does not have their statusbar hidden initially. In any case,

[GitHub] cordova-plugin-camera pull request: StatusBar Hidden Fix

2014-08-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/37#issuecomment-52060180 @DarioDP please see: http://wiki.apache.org/cordova/ContributorWorkflow (ICLA) http://wiki.apache.org/cordova/IssueWorkflow (file a bug in jira; incl

[GitHub] cordova-plugin-camera pull request: StatusBar Hidden Fix

2014-07-17 Thread DarioDP
GitHub user DarioDP opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/37 StatusBar Hidden Fix If I click cancel on imagePicker and I have status bar hidden it re-appear, so I have to hide it also in this case. You can merge this pull request into a Git rep