Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Cordova CI Build has one or more failures.
**Commit** -
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
I have rebased this branch with latest master and merged in in
9d71756e2c6ee243d54eb2c5724c0b0c51dce369.
Thanks for the PR! Will close this separately.
---
If your project
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
I see the problem. Contacts plugin's tests can't handle Android 6+'s
dynamic permission model. We will need to tackle that separately. It works on
Android 5.1, and CI passes there no
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
CI failures eh? Uh oh... hmm... looking into it. I will try to repro
locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Cordova CI Build has one or more failures.
**Commit** -
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Confirmed that this fixes the photo issue - tested on an Android 5.1
emulator.
@infil00p any qualms with merging this in?
---
If your project is set up for it, you can
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
It looks like a JIRA issue is filed for this already:
https://issues.apache.org/jira/browse/CB-10496
---
If your project is set up for it, you can reply to this email and have your
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Cordova CI Build has one or more failures.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Cordova CI Build has one or more failures.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Cordova CI Build has one or more failures.
**Commit** -
13 matches
Mail list logo
