[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers and emails ...

2016-06-01 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2016-05-19 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-220301006 @shazron, unfortunately it doesn't seem to be possible to add automated tests for this feature. Testing this requires linked contact to be

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-219867432 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2016-04-11 Thread 17holeinone
Github user 17holeinone commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-208715996 Not sure this is the right place, but how about a solution to this problem on Android? --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2016-01-05 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-169139723 As usual I would like to see a test in the tests folder for this plugin -- not only to ensure correctness but to ensure this feature is implemented when

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161633720 @MarsupiL, app crash due to missing permissions, while accessing linked contacts already has been fixed in

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-02 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161387695 I don't understand: so what is the bug, and how are we fixing it? I don't have a lot of context on this. Or if we have someone else with a lot of

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#discussion_r46394555 --- Diff: README.md --- @@ -217,6 +217,10 @@ function specified by the __contactSuccess__ parameter. - Windows 8 - Windows

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161241738 > Is this bug saying that the method can't find phone numbers from linked contacts, or that it can't find phone numbers at all? I

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-02 Thread MarsupiL
Github user MarsupiL commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161456736 +1 for resolving this issue. I am using the ng-cordova plugin to pick contacts and almost every contact in my contact book is linked, which

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-01 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#discussion_r46362735 --- Diff: README.md --- @@ -217,6 +217,10 @@ function specified by the __contactSuccess__ parameter. - Windows 8 - Windows

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-12-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161143072 Is this bug saying that the method can't find phone numbers from linked contacts, or that it can't find phone numbers at all? It seems like returning a

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

2015-11-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/88 CB-9348 Fetch phoneNumbers and emails from linked contacts too This fixes [CB-9348](https://issues.apache.org/jira/browse/CB-9348). The idea here is to fetch