Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
Cordova CI Build has completed successfully.
**Commit** -
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@filmaj, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@matrosov-nikita can you rebase with latest master first, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
Just realized you don't have committer rights - I will merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@matrosov-nikita as long as you tested this on one of the real devices
affected by the issue, and confirmed the fix, I am good to have this merged.
---
If your project is
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@filmaj, @infil00p, do I need to do something else on this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user petrot commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
One of my user has a Galaxy J5, but as I recognized yesterday, this phone
does not have a sensor. So my problem has been solved.. :)
---
If your project is set up for it,
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@petrot, what do you mean 'compass problem`. Do you have any particular
cases which don't work for you? I could test them with this fix.
---
If your project is set
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@filmaj, I can confirm that auto and manual tests work w/ my fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
A quick Google search reveals that the Note 2 and Note 4 also have this
sensor type:
http://www.mattcurry.com/projects-2/the-n-a-o-m-i-project/note4-sensor-output/
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@infil00p, sorry for late reply, I've tested a plugin with two Samsung
devices:
1) Samsung Galaxy Core Prime VE Duos SM-G361H (Android 5.1)
