[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-18 Thread tenfef
Github user tenfef commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122514250 Have made said changes to documentation. https://github.com/apache/cordova-plugin-device/pull/36/files#diff-04c6e90faac2675aa89e2176d2eec7d8R173 --- If yo

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-18 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122512809 I think you should add to the readme that users with the app installed will get the previous stored UUID instead of the identifierForVendor --- If y

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-18 Thread tenfef
Github user tenfef commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122511314 I have made the adjustments above to the documentation and also restored the use of NSUserDefaults to maintain backwards compatibility. Jira issue is he

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-17 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122255716 I think you might still want to check in user defaults first, so the uuid value doesn't change for users who already had the app installed. --- If you

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-16 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122194054 First of all, an issue is needed before merging this, create a new one here http://issues.cordova.io/ and use the identifier you get on this pull requ

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-16 Thread tenfef
GitHub user tenfef opened a pull request: https://github.com/apache/cordova-plugin-device/pull/36 Change UUID to use [UIDevice identifierForVendor] instead of generating a UUID, just use the unique identifierForVendor for device which is valid since iOS 6.0 Since Cordova dropped