Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46653820
--- Diff: tests/tests.js ---
@@ -31,9 +31,11 @@ exports.defineAutoTests = function () {
var ONE_SECOND = 1000; // in
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46581788
--- Diff: src/windows/FileTransferProxy.js ---
@@ -49,6 +49,17 @@ function nativePathToCordova(path) {
return
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46582720
--- Diff: README.md ---
@@ -230,6 +230,10 @@ __Parameters__:
- Download requests is being cached by native implementation.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161746483
The mention of BackgroundUploader/Downloaded in the Windows quirks section
confused me a bit.
At first, I thought they were some options we
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161817573
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46627985
--- Diff: tests/tests.js ---
@@ -31,9 +31,11 @@ exports.defineAutoTests = function () {
var ONE_SECOND = 1000; // in
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161733972
@dblotsky, @jasongin, I've addressed the CR notes and also added a few
fixes for the last commit changed the timeouts - please take a look.
---
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46454382
--- Diff: src/windows/FileTransferProxy.js ---
@@ -49,6 +49,17 @@ function nativePathToCordova(path) {
return
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46446244
--- Diff: tests/tests.js ---
@@ -29,6 +29,7 @@ exports.defineAutoTests = function () {
// constants
var
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46445757
--- Diff: README.md ---
@@ -230,6 +230,10 @@ __Parameters__:
- Download requests is being cached by native implementation.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161286724
@dblotsky, could you please review once more?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928589
--- Diff: tests/tests.js ---
@@ -468,6 +468,8 @@ exports.defineAutoTests = function () {
it("filetransfer.spec.10
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928488
--- Diff: src/windows/FileTransferProxy.js ---
@@ -152,6 +158,18 @@ exec(win, fail, 'FileTransfer', 'upload',
try {
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928789
--- Diff: tests/tests.js ---
@@ -450,7 +450,7 @@ exports.defineAutoTests = function () {
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928408
--- Diff: src/windows/FileTransferProxy.js ---
@@ -116,9 +118,13 @@ exec(win, fail, 'FileTransfer', 'upload',
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118
CB-8641 Some file-transfer plugin tests occasionally fail in mobilespâ¦
â¦ec on Windows Phone 8.1
Increases timeouts for Windows platform in abort tests
Adds
17 matches
Mail list logo
