[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-99359895 Can we consider #54 again, now that apache/cordova-wp8#79 has been integrated? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-05-05 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-99129950 We need this one to be fixed soon - Personally, I prefer @vladimir-kotikov incremental fix than a major version bump for WP8 platform with Newtonso

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-04-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-88908206 Not yet. After we do wp8 4.0.0 with json.net. Otherwise we need to write every possible data contract. --- If your project is set u

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-04-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-88864506 @purplecabbage, @nikhilkh are you ok with merging this? --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-03-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-86671373 Yep, they're allowed if you have corresponding data contract. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-03-26 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-86642247 I think the DataContractJsonSerializer is gonna choke on some possible (valid) json data. Nested objects are allowed, are they not? --- I

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-03-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-86594703 Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-03-26 Thread mowcixo
Github user mowcixo commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-86591690 Sure. Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-03-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-86588650 @mowcixo, if you're ok with this approach, could you please close apache/cordova-wp8#62 and the apache/cordova-plugin-file-transfer#54 --

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-03-26 Thread mowcixo
Github user mowcixo commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-86503166 I think it's correct. It does not solve the root of the problem, but customizing each plugin that uses headers, will be a good solution. As

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-03-25 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72 CB-8721 Fixes incorrect headers and upload params parsing on wp8 This is a bugfix for [CB-8721](https://issues.apache.org/jira/browse/CB-8721) which replaces custom pa