Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41202671
@machenmusik the sign up is confusing. You have to click Log In to see the
sign up link: https://issues.apache.org/jira/secure/Signup!default.jspa
Github user machenmusik commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41202400
@jesse the version change was just so one could tell version I was using a
modified version. (mac being my initials)
I assume you would c
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41199740
@machenmusik file an issue at https://issues.apache.org/jira/browse/CB, and
get the issue number in the form of CB-. Edit the title of this PR to
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#discussion_r11916904
--- Diff: plugin.xml ---
@@ -2,7 +2,7 @@
http://apache.org/cordova/ns/plugins/1.0";
xmlns:android="http://schemas.and
Github user machenmusik commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41198810
of course you wouldn't pull it in without understanding "why", but I would
not ever expect reading the commit message alone to explain the "wh
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41195514
Of course "why" matters, especially to a committer (the code already is
"how"). There is absolutely no reason to add code that you don't understand w
Github user machenmusik commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41192886
The title on the commit was what it does, not why. Can see if pull
requests can have different titles (I think github automatically sets to comm
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41113506
Ah ok, I get it now - the title of this PR was confusing (I was trying to
solve what it stated). This would be useful if you had to do a PUT to a RES
Github user machenmusik commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-40996223
In this use case, direct upload without the multipart encoding is
desirable, so disallowing the header and forcing multipart upload would have
t
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-40995178
I understand the problem, but wouldn't it be better if we just filtered out
"Content-Type" for user-defined headers? (disallow setting it)
---
If y
GitHub user machenmusik opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/27
on iOS, Android and Amazon, if upload has a header named Content-Type,
multipart form data will NOT be used
You can merge this pull request into a Git repository by runnin
11 matches
Mail list logo
