Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#discussion_r46821107
--- Diff: www/isChrome.js ---
@@ -0,0 +1,26 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162621624
Would it not be better to use the useragent to detect if the browser we're
dealing with is chrome ?
---
If your project is set up for it, you can reply
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708771
@omefire - no, I don't think so. I think feature detection is more
appropriate for the intent of this code. Also, my goal wasn't to change the
existing
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708869
Moved `isChrome` to be browser specific (we only ever call it either from
browser specific code, or after verifying we're running on browser platform).
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162436942
Looks good to me :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#discussion_r46792384
--- Diff: www/isChrome.js ---
@@ -0,0 +1,26 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
