[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2015-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2015-01-22 Thread vldmrrr
Github user vldmrrr commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/89#issuecomment-71146158 rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2015-01-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/89#issuecomment-71135590 Please rebase, + fix the merge conflict, and I will re-evaluate. Strange this is, when I just update the tests.js file, we only have 1 failing t

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2015-01-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/89#issuecomment-71045384 Not yet. On it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2015-01-22 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/89#issuecomment-71035666 @purplecabbage is there any news on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2015-01-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/89#issuecomment-68809868 Initially it looks good. I am a little weary of some of the differences between all the platforms though, and would like to look at this some more befo

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2015-01-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/89#issuecomment-68692804 @purplecabbage Could you pls. take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2014-12-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/89#issuecomment-66962414 @purplecabbage Could you pls. take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2014-11-01 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-file/pull/89 Rework to use normal url form on windows platform CB-7883: toURL method called on etnries returned by resolveLocalFileSystemURL and getDirectory produces path instead of URL. T