Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-208616871
Minor comments. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r59298774
--- Diff: README.md ---
@@ -538,3 +540,296 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r59298517
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also implements
1. Browser platform... the one under discussion.
2. I understood everything you say in your response paragraphs 2 and 3.
3. My points still remain... your statement "many of these APIs..." is
confusing.
4. Your words in paragraphs 2 and 3 of your response should be included as
clarification.
5. Rep
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207123605
Rob, what platform are you looking at?
The W3C FileSystems spec for web browsers is deprecated; what that
effectively means is no other browsers w
Github user RobPosener commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207120687
I am able to get all of the File System APIs that I require to work
correctly. I can create directories and sub-directories. I can create files
and re
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207076949
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58929077
--- Diff: README.md ---
@@ -538,3 +540,298 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928914
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also implements
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58927585
--- Diff: README.md ---
@@ -36,9 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also implements
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928337
--- Diff: README.md ---
@@ -671,89 +718,111 @@ window.requestFileSystem(window.TEMPORARY, 5 * 1024
* 1024, function (fs) {
}, onErrorLoadFs
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928048
--- Diff: README.md ---
@@ -671,89 +718,111 @@ window.requestFileSystem(window.TEMPORARY, 5 * 1024
* 1024, function (fs) {
}, onErrorLoadFs
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442897
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442531
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442202
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58441628
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58441476
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58440889
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58439895
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: Th
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58438965
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also implements
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58276468
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: The
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58275738
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
* `root`: The
GitHub user Mikejo5000 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/176
adding sample section to readme
removed link to current complete sample, related edits
You can merge this pull request into a Git repository by running:
$ git pull https://githu
24 matches
Mail list logo
