Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-207138136
please close. we got osx support in the meantime added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-207121298
This pr is hopelessly out of date. If it is still relevant, please rebase
it, otherwise I will be closing it shortly.
---
If your project is set up fo
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-52084825
@onflapp please see:
http://wiki.apache.org/cordova/ContributorWorkflow (ICLA)
http://wiki.apache.org/cordova/IssueWorkflow (file a bug in jira; include
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221118
--- Diff: src/ios/CDVFile.m ---
@@ -313,11 +313,9 @@ - (void)pluginInitialize
--- End diff --
Since you are doing the copy route
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221112
--- Diff: plugin.xml ---
@@ -212,6 +212,27 @@
xmlns:android="http://schemas.android.com/apk/res/android";
+
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-41845829
I think you should check our editor settings. it looks like the lines you
changed have the wrong indentation. make sure you have "replace tabs with
spaces"
Github user tripodsan commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12163593
--- Diff: src/osx/CDVFile.m ---
@@ -0,0 +1,1024 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contrib
Github user tripodsan commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12163564
--- Diff: src/osx/CDVLocalFilesystem.m ---
@@ -0,0 +1,719 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or mo
Github user tripodsan commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12163518
--- Diff: src/ios/CDVFile.m ---
@@ -313,11 +313,9 @@ - (void)pluginInitialize
--- End diff --
why is this changed? I thought y
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12157924
--- Diff: doc/index.md ---
@@ -69,6 +70,10 @@ Android also supports a special filesystem named
"documents", which represents a
By defaul
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12157876
--- Diff: plugin.xml ---
@@ -203,6 +203,27 @@
xmlns:android="http://schemas.android.com/apk/res/android";
+
GitHub user onflapp opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/42
updated support for the OS X platform
- copying all the files to osx
- making sure it works with the latest osx platform
You can merge this pull request into a Git repository by runn
13 matches
Mail list logo
