[GitHub] cordova-plugin-geolocation pull request: [CB-7158] fix geolocation...

2014-09-09 Thread weili-feedhenry
Github user weili-feedhenry closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] cordova-plugin-geolocation pull request: [CB-7158] fix geolocation...

2014-09-09 Thread weili-feedhenry
Github user weili-feedhenry commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/21#issuecomment-54972445 @shazron Thanks. I will close this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-plugin-geolocation pull request: [CB-7158] fix geolocation...

2014-09-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/21#issuecomment-54906754 Patched, thanks! Please close this PR. https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=4102a33 --- If your project is

[GitHub] cordova-plugin-geolocation pull request: [CB-7158] fix geolocation...

2014-09-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/21#issuecomment-54903964 @weili-feedhenry thanks for the patch! Just confirming that this is you on the list for ppl that have submitted an iCLA: http://people.apache.org/comm

[GitHub] cordova-plugin-geolocation pull request: [CB-7158] fix geolocation...

2014-08-15 Thread weili-feedhenry
Github user weili-feedhenry commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/21#issuecomment-52285921 @rpassis You are right. Thanks for the patch! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-geolocation pull request: [CB-7158] fix geolocation...

2014-08-14 Thread rpassis
Github user rpassis commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/21#issuecomment-52274202 This pull request only partially solves the new API changes / requirements. You will also need to include a new key (NSLocationWhenInUseUsageDescriptio

[GitHub] cordova-plugin-geolocation pull request: [CB-7158] fix geolocation...

2014-08-13 Thread seanarnold
Github user seanarnold commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/21#issuecomment-52118213 @weili-feedhenry Thanks for this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-plugin-geolocation pull request: [CB-7158] fix geolocation...

2014-08-08 Thread weili-feedhenry
GitHub user weili-feedhenry opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/21 [CB-7158] fix geolocation for ios 8 See https://issues.apache.org/jira/browse/CB-7158 You can merge this pull request into a Git repository by running: $ git pull htt