Github user daserge closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183559873
Please review #70. It looks like it specifically fixes the behaviour to
match what's expected.
---
If your project is set up for it, you can reply
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183559781
@daserge this change will change an *existing* listener, which is not
expected behaviour. It is expected that when `addWatch` is called a second
tim
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183442760
@sarangan12, listeners are removed and then subsribed again.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183439690
@daserge I am not sure if removing the event listeners is a good idea. From
the user perspective, there is no reason for him to have only one event
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183411853
@dblotsky, @sarangan12, I've updated the PR, please take a look.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#discussion_r52679939
--- Diff: tests/tests.js ---
@@ -174,8 +174,12 @@ exports.defineAutoTests = function () {
describe('error callback', function
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69
CB-10594 geolocation.spec.10 crashes Windows Phone 8.1
[Jira issue](https://issues.apache.org/jira/browse/CB-10594)
You can merge this pull request into a Git repository by runnin
