Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
I will look through the proposed changes next week and resolve conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
@jcesarmobile - updated to remove that duplicate code, tested in my app and
it's working well.
---
If your project is set up for it, you can reply to this email and have your
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
Cordova CI Build has one or more failures.
**Commit** -
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
Oh I see now, sorry I misunderstood.
I can definitely make that change
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
I didn't meant to reuse the existing hide, but make the old hide just call
the new browserHide as browserHide has the exact same code
```-
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
The new methods follow what is implemented for close, where there are 2
close methods, one designed for the user to call and one for use with a
selector that the done button
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
The existing hide and the new browserHide do exactly the same, can you make
the old hide just call browserHide instead of duplicating code.
Can you try adding this
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
Cordova CI Build has completed successfully.
**Commit** -
