Github user dblood commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
I dug through the code quite a bit and think I have found why this was so
hard to reproduce for me. (restoring the version I had in my repo instantly
caused the problem though).
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dblood commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
I've spent many hours trying to build a manual test in a "clean"
environment. When I get to the office on Monday I can recreate it there and
start pulling code out until I have
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
Yeah, I think that's fine (for not writing an automated test) in this case.
It is a very difficult scenario to reproduce - as you mentioned, it may take 5
minutes. But, if we
Github user dblood commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
Of course. I will work on a test script. The library I was using is
https://github.com/IdentityModel/oidc-client-js
with type of "id_token token" and monitoring on. This
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
@dblood OK, so what do I need to do to test this thing to verify this
works? Do you have a monitor script available somewhere? Please don't check
off the last box if there's
Github user dblood commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
Because the core issue behind this null pointer is threading, having a
automated test that would work consistently 100% of the time isn't possible and
a flaky test is a bad thing
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
What tests have you added?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
Cordova CI Build has completed successfully.
**Commit** -
