[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

2017-08-15 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 @filmaj, sure, my congratulations :) @stevengill, could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

2017-08-15 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 Hey, i'm on vacation for the next couple of weeks (getting married!). CAN you get someone else to review? Perhaps @stevesgill On Aug 15, 2017 11:50 AM, "Nikita

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

2017-08-15 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 @filmaj, I've added a section in docs for Data URIs, could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

2017-07-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 Ideally this kind of stuff lands across all major platforms in Cordova. Generally, if something is not doable due to platform-specific restrictions, we, at the minimum,

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

2017-07-27 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 @filmaj, I would expand this section (https://github.com/apache/cordova-plugin-inappbrowser#more-usage-info) by adding samples with Data URIs. But, for now, I

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

2017-07-24 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 Seems that it's supported on browser platform only (for now I've verified for android, windows, ios, browser platforms). I've updated PR to add support for windows

[GitHub] cordova-plugin-inappbrowser issue #227: CB-12969 android: Added support for ...

2017-07-19 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 Is this supported on any platforms other than iOS? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project