[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-04-07 Thread JPustkuchen
Github user JPustkuchen commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-207060533 +1 for this merge. A really useful feature! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-29 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-190311984 When I created this, it was meant to be used as a proof of concept for something at my place of employment. We recently dropped this path so I

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-28 Thread tanansatpal
Github user tanansatpal commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-190036800 Hello @Sinistralis, I am also using Xwalk for my android app. It would be a great help if this feature is introduced. --- If your project

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-24 Thread JoMas971
Github user JoMas971 commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-188254202 Hello @Sinistralis, can you give us an update ? I also need this for my app, i'm actually using Xwalk (for android development, you can't

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-13 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-183625072 Ok, so its looking like I can spend some time on this tommorrow (or today really. I'm up way too late). I went ahead and cleaned up the

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-09 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-182066306 I've been meaning to come back to this. I've been incredibly busying reforming the front-end process at my job. I'm trying to find the time but

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-09 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-182007524 Is there work being done on this? It'd probably be good to update the pull request so that it can be more easily tested against the current

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-08 Thread refactorthis
Github user refactorthis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-181574443 Any news on this one? I also need this functionality. We have a somewhat common scenario of using third party oauth provider in isolated

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-12-03 Thread nicoabie
Github user nicoabie commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161656697 Thanks @Sinistralis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-12-02 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161420725 When you say you do not get cookies set, are you talking about using this code or default functionality? I did not test against XWalk, but I

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-12-02 Thread nicoabie
Github user nicoabie commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161486476 Sorry for not being explicit enough, I made a fork of the inappbrowser code and applied this pull request. I'm using XWalk and debuggind the code

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-12-01 Thread nicoabie
Github user nicoabie commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161011305 Does this work when using XWalk? Is there any way to make it work using XWalk? Because we are not getting any cookies setted. Thanks in advance

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread Sinistralis
GitHub user Sinistralis opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122 Added Android cookie sharing functionality between webviews There currently exists a gap in functionality with Android as opposed to iOS where iOS will actively share

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152334883 >The fact that iOS shares cookies is a defect imho. I would be completely ok with agreeing with this. I just want constancy,

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152319159 The fact that iOS shares cookies is a defect imho. That said, I think what 'should' happen is that this 'feature' should be exposed as an

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152337481 Correct, my thought process was that you would want to absolutely clear these cookies upon closing the app. Which leads into a

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152341159 The clear-cache options also clear the cookies in the inappbrowser before a page loads, so if you wanted to load something you didn't trust,

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152337087 Thanks for the info. I think this is actually fine, as long as the options `clearsessioncache` and `clearcache` are honored, as

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152341785 I think we have different concerns here even though we agree on the same thing. If the app developer is concerned about exposing their