[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-219915534 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/164/com

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-05-01 Thread Alex-Sessler
Github user Alex-Sessler commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-216067702 I wanted to change my solution to also cover the edge case where a user could have the app secured but doesn't want the IAB to be secured. I en

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-05-01 Thread Alex-Sessler
Github user Alex-Sessler commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-216067099 Okay, so I added a "securewindow" flag, that allows you to set the FLAG_SECURE on the IAB Dialog. Since I use a highly modified custom IAB vers

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread Alex-Sessler
Github user Alex-Sessler commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215814096 I think i could have time to add this some time this weekend. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215812203 +1 for option. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215792971 Does it make sense to have this be an iab option? Could a non-secure activity want to display a secure iab? Maybe that is step 2. This loo

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215697044 Well, it certainly works as advertised with the PrivacyScreenPlugin, anyway. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215685335 Nice, I'll try to have a look at this as well. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread Alex-Sessler
GitHub user Alex-Sessler opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164 Added FLAG_SECURE support I'm using this Plugin together with the Privacyscreen Plugin (https://github.com/devgeeks/PrivacyScreenPlugin), which sets the FLAG_SECURE on the