[GitHub] cordova-plugin-inappbrowser pull request: CB-10866: Adding engine ...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-inappbrowser pull request: CB-10866: Adding engine ...

2016-05-17 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-219883643 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cordova-plugin-inappbrowser pull request: CB-10866: Adding engine ...

2016-05-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-219869580 @rakatyal take a look real quick. The docs for this feature are [here](http://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html#spec

[GitHub] cordova-plugin-inappbrowser pull request: CB-10866: Adding engine ...

2016-03-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-198467454 @stevengill that old engine info wasn't doing anything, right? I'm good to remove it? --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-inappbrowser pull request: CB-10866: Adding engine ...

2016-03-19 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-198494320 Yup! It was a early attempt to do what your proposal does. No code checks it. --- If your project is set up for it, you can reply to this emai

[GitHub] cordova-plugin-inappbrowser pull request: CB-10866: Adding engine ...

2016-03-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/155 CB-10866: Adding engine requirements to package.json You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plu