Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176320293
setTimeout is required to support the following scenario. On ios, android
and other platforms functionality creates InAppBrowser on native side, so
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176293276
Also, I would recommend using `setImmediate` as it has advantages over
`setTimeout(fn, 0)`.
https://msdn.microsoft.com/en-us/library/windows/apps/
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176292095
I'm curious why those `setTimeout()` calls are required.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176290461
LGTM. Looks like these bugs have been there for a while and this is not a
recent regression that this change is addressing.
---
If your project i
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176253919
Use the following url to review proposed changes w/o whitespace:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145/files?w=1
---
If
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145
InAppBrowser bugfixing on Windows: CB-10451, CB-10452, CB-10454
CB-10451 InAppBrowser: loadstart event is not triggered on Windows
CB-10452 InAppBrowser: 'exit' event is not
