[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-05-17 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-219919340 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171893568 You are correct, thanks for helping me to see it. The meaning of 'location' is somewhat vague. I will test this pr in the morning and

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-14 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171895107 That's what toolbar option makes on iOS toolbar: set to yes or no to turn the toolbar on or off for the InAppBrowser (defaults to

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-13 Thread mvirkkunen
GitHub user mvirkkunen opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134 Make WP respect location=no The WP version reads the location parameter but seemingly never uses it. This would make it hide the "AppBar" with the back/next/exit buttons

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171465970 The WP version does not show a location bar, so this is irrelevant, hiding AppBar is not even close to the same thing. If you want to make WP

[GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...

2016-01-13 Thread mvirkkunen
Github user mvirkkunen commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171479628 As far as I could tell on Android at least it hides the bar with the back/next buttons. It would also be in line with how browsers such as