[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2016-04-27 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-215002415 I've changed the implementation a bit. Currently defining additional property with custom application scheme is not required anymore. --- If your pro

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2016-04-07 Thread JPustkuchen
Github user JPustkuchen commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-207061483 I can confirm that this is really an important feature request. For example we want to use skype:// and whatsapp:// links within the webview. The

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2016-02-16 Thread NGumby
Github user NGumby commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-184857676 I think a better approach to communicate between an external website and the app, is to raise an event in shouldOverrideLoadUrl like this : `

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-12-16 Thread iampeter
Github user iampeter commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-165376605 Could this change be introduced? Seems that on some Android devices the "_system" parameter doesn't help with the custom URL scheme. --- If your p

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-28 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-87192378 I agree that it is responsibility of the parent to dismiss the inAppBrowser (fixed that), but from the other hand it is also responsibility of the webVi

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-87025912 It should not redirect, it should send a message to it's parent ( the application webview ) The parent should then dismiss it's child (InApp

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-27 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-86966392 We don't want to system browser. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-27 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-86966069 Maybe I'm missing something. The problem which we faced with the current inAppBrowser plugin implementation is that it doesn't allow to perform the red

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-26 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-86389973 I can't understand what this changes try to achieve. Looking at the code it launchs an intent to open an external app if the url is defined on th

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-26 Thread osvso
GitHub user osvso opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 inAppBrowser custom application scheme handling on android Currently the inAppBrowser doesn't handle custom application scheme making it impossible to redirect back to the nativeC