Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Per [CB-12542](https://issues.apache.org/jira/browse/CB-12542), I will
merge in the wav/m4a support, and we will look at the separate `getDuration`
issue @leopatras described in the
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Here are the relevant bits of test code I am working with:
```
initialize: function() {
document.addEventListener('deviceready',
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Actually, I spoke too soon. I think I will pull in everything but the last
commit - that seems like a new command being added.
I will retest with all commits but that last one
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
OK, verified this works with both .wav and .m4a on an iPhone 5S running iOS
10.2. Hooray!
I will be rebasing and pulling this in shortly, and then will close this PR
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
@leopatras while I verify this PR, do you have an [Apache
ICLA](https://www.apache.org/licenses/icla.pdf) signed and sent to
secret...@apache.org?
---
If your project is set up for
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
I am taking a look at this today. Will rebase and run some tests locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user dylanvdmerwe commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Please can someone review this PR. This is a very suitable fix for a real
problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user Iyashu5040 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Thanks so much @leopatras for this fix. I'm using your version of this
plugin while we wait for the PR to be merged.
---
If your project is set up for it, you can reply to this
Github user LoneyGG commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
@shazron Please review this pull request, is working perfectly and hasn't
been merged yet! :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user leopatras commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
@shazron What prevents the pull request from being merged ? Anything I can
do further ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/134/commits/80cbffe9bc620df72090ae60b5360b874f8a3b86)
Github user LoneyGG commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Why this hasn't been merged yet? its a pain to apply the fix manually and
remove this plugin from the gitignore in order to share my code with my
partners.
---
If your project is set
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Cordova CI Build has completed successfully.
**Commit** -
16 matches
Mail list logo
