[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-06-06 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Sweet, I'm down with merging this in. Small nit: if you could rebase w/ latest master and combine the commits into one that'd be fantastic! @infil00p any concerns from you on

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-06-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-06-06 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 (hopefully this triggers the CI) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-06-06 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-04-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Hmm, looks like all three CI runs against Android (4.4, 5.1, and 6.0) failed. Output for these three test runs: - Android 4.4:

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-04-25 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/137/commits/36e4fdf22820f750d96774e0e254327aca062dec)

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-04-25 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-03-24 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/137/commits/36e4fdf22820f750d96774e0e254327aca062dec)

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

2017-03-24 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Old PR: #121 One question: I couldn't test the `onMessage(String id, Object data) {` method and its affects. when is this triggered? --- If your project is set