[GitHub] cordova-plugin-network-information pull request: Fix network infor...

2014-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-network-information pull request: Fix network infor...

2014-09-12 Thread rodms10
Github user rodms10 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-network-information/pull/19#discussion_r1747 --- Diff: src/firefoxos/NetworkProxy.js --- @@ -34,8 +34,16 @@ module.exports = { getConnectionInfo: function(successC

[GitHub] cordova-plugin-network-information pull request: Fix network infor...

2014-09-12 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/19#issuecomment-55381961 r+ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-network-information pull request: Fix network infor...

2014-09-12 Thread zalun
Github user zalun commented on a diff in the pull request: https://github.com/apache/cordova-plugin-network-information/pull/19#discussion_r17470520 --- Diff: src/firefoxos/NetworkProxy.js --- @@ -34,8 +34,16 @@ module.exports = { getConnectionInfo: function(successCal

[GitHub] cordova-plugin-network-information pull request: Fix network infor...

2014-09-11 Thread rodms10
GitHub user rodms10 opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/19 Fix network information type exception on fxos 2 `navigator.connection` got removed from fxos 2, causing the plugin to crash when loading. Fixed by returning `UNKNOWN` wh