[GitHub] cordova-plugin-network-information pull request: Performance-relat...

2015-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-network-information pull request: Performance-relat...

2015-07-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/30#issuecomment-125736123 Thanks, I am planning to remove all string comparisons one day and actually use the defined types, but this does help in the meantime.

[GitHub] cordova-plugin-network-information pull request: Performance-relat...

2015-07-28 Thread SidFerreira
GitHub user SidFerreira opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/30 Performance-related fix Move all conversions to line 236, saving ~14 tests You can merge this pull request into a Git repository by running: $ git pull https://g