Github user bjomi commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
great! thanks for quick response @purplecabbage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
cleaned up a few merge issues, this is now in master, thanks @cnspaha
Next the plugin will need to go thru the typical Apache vote process before
being pushed to
Github user bjomi commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
@purplecabbage great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
there is nothing more that @ego7repo can do.
I am reviewing this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bjomi commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
@ego7repo +1. Please get this fix out now so that the plugin becomes usable
on iOS. Right now it isn't unfortunately.
---
If your project is set up for it, you can reply to
Github user ego7repo commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Please push to NPM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Tawsif commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Latest commits are not reflected in main repository code. Please do the
needful
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Cordova CI Build has one or more failures.
**Commit** -
Github user cnspaha commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
I don't know why it don't work on phonegap build, since I don't use it, I
can't reproduce.
---
If your project is set up for it, you can reply to this email and have your
Github user Tawsif commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Please resolve this ASAP. As the changes are not reflected on phonegap
build. So I am not able to test it
---
If your project is set up for it, you can reply to this email
Github user nowitz commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
I have same problem with dependencies:
"@ionic-native/screen-orientation": "^3.4.4"
and plugin:
"name": "cordova-plugin-screen-orientation",
"version":
Github user iamehiz commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
This do not work, after uploading to phonegap build, don't know why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Cordova CI Build has completed successfully.
**Commit** -
Github user Sh1d0w commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
@cnspaha Can you advise on the issue above, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cnspaha commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
@purplecabbage
applied your proposed changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Sh1d0w commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
The proposed fix works ok (reverted `screenObject.nativeLock !== null` back
to `screenObject.nativeLock != null`), expect that it does not force rotate the
screen if you are
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
If this is still valid, please rebase. Otherwise it will be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Cordova CI Build has one or more failures.
**Commit** -
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Cordova CI Build has one or more failures.
**Commit** -
21 matches
Mail list logo
