Github user uj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@Lazza Ok, i just tried your fix, and it crashes less often, but not 100%
crash-free. However, this mostly happens when using the back-button to "exit"
the program. There is a
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@uj does my fix work on that device as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user uj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Will this fix be added to the official apache version? I can confirm that
cordova-plugin-splashscreen crashes Morotola X Gen 3, Android 6, not just
Samsung devices.
---
If your
Github user karlachavez commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Your suggest works fine. The splashscreen is not displayed on the device we
had the problem, but on the rest of devices. We are going to take this
workaround until an
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Are there any news on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@karlachavez
> we have to remove the splashscreen of our app
In the meantime:
cordova plugins remove cordova-plugin-splashscreen
cordova
Github user karlachavez commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
We can reproduce this issue on a Samsung S6 with the following tech specs:
http://www.samsung.com/ca/business/business-products/smartphones/smartphones/SM-G920WZWABMC
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@vegetablesalad which devices exhibited the behaviour of splash screen not
showing up? Brand and model names/numbers, along with Android operating system
versions running on
Github user vegetablesalad commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
I can attest to this bug. Splash screen didn't show up on 5 of my test
phones. Applying this resolved the issue.
---
If your project is set up for it, you can reply to
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@filmaj, @infil00p unfortunately I do not have access to many Samsung
devices. I was able to test this plug-in only with the models mentioned in the
PR.
As @SamDelgado
Github user SamDelgado commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
I have a Samung Galaxy S7 Edge that experienced an immediate crash when my
app launched. This pull request fixed it.
---
If your project is set up for it, you can reply to
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@Lazza Which Samsung Devices would have this problem? Would a Samsung
Galaxy S3 to S8 have this?
---
If your project is set up for it, you can reply to this email and have
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Hmm, I cannot seem to reproduce the error with the latest master of
cordova-android + cordova-plugin-splashscreen.
I'm using a ~200kb .png file as a splash screen. Here's
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
I think I have a Samsung S5 that I can play with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Yeah, but unfortunately... I am not even sure how I got that one to crash!
ð
Most of my tests in the emulators where either working or simply not
showing the splash (but not
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
O nice, there is an emulator in there. OK, I will try to reproduce. Thank
you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@filmaj I see. ð Just to be clear, my PR is released under the Apache
Version 2.0 license as anything else in this repo (it is also the license
mentioned in the project and
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
One more question: how would one go about reproducing the crash that this
patch fixes? What device did you see the crash on?
---
If your project is set up for it, you can reply
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@Lazza nevermind, it is not completely required. Issuing a PR is enough to
establish "intent to contribute" which is all Apache legal requires.
---
If your project is set up for
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@filmaj I don't think I have. Why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Ping @infil00p for a review.
@Lazza have you signed an ICLA for Apache?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Great! Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@Lazza I was just restarting the tests :) As you can see, they are green
now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@alsorokin, sure, go ahead. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Cordova CI Build has completed successfully.
**Commit** -
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
> Cordova CI Build has one or more failures
This doesn't make sense. The build log states that the failure is on the
Windows build. This PR **does not make any
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Cordova CI Build has one or more failures.
**Commit** -
28 matches
Mail list logo
