[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-10-14 Thread Clafou
Github user Clafou commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-59035417 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-10-14 Thread Clafou
Github user Clafou closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-58969064 Sorry everyone but I had to do a major re-factor to support unit-testing the different configurations of splash screens (effectively over 200 plus tes

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-57030949 Yeah GUI methods won't work since we have to support the CLI. In any case, this issue is already fixed see subtasks 48-53 of https://issues.apache.or

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-26 Thread MrJustastic
Github user MrJustastic commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-56929912 I found this post which outlines how you can simply turn on support for the extra launch image types in your image assets. Drag'n'Drop FTW and a m

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-56758804 Added an issue for this PR: https://issues.apache.org/jira/browse/CB-7633 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-56758706 https://issues.apache.org/jira/browse/CB-7632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-56758000 From here: http://stackoverflow.com/a/25960203 Adding this key below to Info.plist should support the old default naming schemes, plus the new iPh

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55958394 Ok, sounds good as a stop-gap - with #17 this could be viable. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-17 Thread Clafou
Github user Clafou commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55948054 Given the new and recommended splash screen approach in iOS8, it seems that there is naming convention for the iPhone 6. However it is possible to use

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55930672 Definitely, I've commented on other splash screen PRs that we need to go with that modern (and more sane) approach, but that's more of a migration pat

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-17 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55928732 And [this document](https://developer.apple.com/library/prerelease/ios/documentation/UserExperience/Conceptual/MobileHIG/LaunchImages.html) linked f

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55919550 Not sure if that is Apple convention for the new iPhones. At least nothing here: https://developer.apple.com/library/prerelease/ios/documentation/Gen

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-17 Thread Clafou
GitHub user Clafou opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26 Added support for iPhone 6 and iPhone 6 Plus resolutions The iPhone 6 and iPhone 6 Plus brings new resolutions for the splash screen. Taking the same approach as with the iPhone 5