Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-186485912
@daserge Have you tested this and verified it's working? I have the
splashscreen plugin v3.2.0, and have manually converted my existing
`cordova-ios
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-167555343
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-167517585
@jcesarmobile, thanks for reviewing, I've addressed the notes.
Looks like these prefixes mean iOS version and I believe it's not
documented.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-167371442
Where do these prefixes come from? is that documented? I've found this
http://stackoverflow.com/questions/19107543/xcode-5-asset-catalog-how-to-
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#discussion_r48450641
--- Diff: src/ios/CDVSplashScreen.m ---
@@ -187,7 +187,35 @@ -
(NSString*)getImageName:(UIInterfaceOrientation)currentOrientation de
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#discussion_r48450615
--- Diff: src/ios/CDVSplashScreen.m ---
@@ -187,7 +187,35 @@ -
(NSString*)getImageName:(UIInterfaceOrientation)currentOrientation de
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#discussion_r48450551
--- Diff: src/ios/CDVSplashScreen.m ---
@@ -187,7 +187,35 @@ -
(NSString*)getImageName:(UIInterfaceOrientation)currentOrientation de
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-167346221
@shazron, could you please take a look when possible?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69
CB-10263 Fix splashscreen plugin filenames for Asset Catalog
[Jira issue](https://issues.apache.org/jira/browse/CB-10263)
You can merge this pull request into a Git repository by
10 matches
Mail list logo
