Github user pppglowacki commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-129428816
@jacobg @shazron looks like we are also getting a similar crash. Did
someone figure this out?
---
If your project is set up for it, you can rep
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-101761529
Hi @shazron: I'm still getting the same crash from users after applied the
latest fix. Any ideas? Thanks.
---
If your project is set up for it, you
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91347597
Filed a new issue: https://issues.apache.org/jira/browse/CB-8836
---
If your project is set up for it, you can reply to this email and have your
repl
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91346209
No, thank you for the reports, that has helped solve the issue.
I'll pull the changes in anyway. Admittedly this is sloppy work on our part
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91344385
Sounds good. I'm having trouble repro'ing the crashes; I've only personally
seen it twice after a zillion attempts. But I'm definitely getting the repo
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91343883
Yes, definitely. I'll let you try it out for bit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91343025
Are you planning to commit this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91342982
Great thanks @shazron !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91339823
Yes it definitely can not crash every time -- but it's a certainty that it
would eventually.
---
If your project is set up for it, you can reply to
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91339236
Hmm. Can it be that it would not crash every time? AutoHideSplashScreen is
false, and navigator.splashscreen.hide is called in javascript.
Tha
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91338139
Actually, this needs to be wrapped as well:
https://gist.github.com/shazron/e45705f76bef4448139a/daddb1f1fefc6171589b2c79bb9333efe6603ed6#file-gis
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91337249
I've updated my gist with a fix:
https://gist.github.com/shazron/e45705f76bef4448139a/daddb1f1fefc6171589b2c79bb9333efe6603ed6
---
If your proje
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91335908
Ugh - it's related.
Basically, when calling this:
https://gist.github.com/shazron/e45705f76bef4448139a#file-gistfile1-m-L15
...it call
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91333840
I just got the following new crash group. Do you think it's the same issue?
```
Incident Identifier: DD4D6021-EC75-4FFC-949E-2156E433A5F6
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89891961
Thanks so much @shazron. I will try your patch.
Here is a raw crash log:
```
Incident Identifier: FF007664-79D7-4895-99C8-F93D8884
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89458111
This could be it:
1.
https://github.com/apache/cordova-plugin-splashscreen/blob/d2e62a551c950041cb4c9683624a04d931f4bee3/src/ios/CDVSplashScreen.m
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89449427
@jacobg not too sure what's going on here. Post the full crash log
somewhere? (shot in the dark). I'll review the code again.
---
If your project is
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-88049413
Ever since I added the splashscreen plugin to my app, I (and customers)
have been getting this crash occasionally:
```
1 libobjc.A.dylib
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-58344161
Yes. I probably agree with using `finished` parameter for the fix.
---
If your project is set up for it, you can reply to this email and have your
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-55830716
Not sure what you meant exactly by your last comment. So is my proposed fix
would be the better way in your opinion?
---
If your project is set up f
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-55703938
Sorry, I reread your comment and realize that my earlier comment is
probably off-topic.
---
If your project is set up for it, you can reply to this
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-55702064
When you are really fast this is not working. New view created before call
to `[self destroyViews];` happens inside callback and application crash wh
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-55677107
I'm thinking the proper fix is to check whether finished == YES here, then
call destroyViews:
https://github.com/apache/cordova-plugin-splashscre
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-50960520
Probably another place to fix is
https://github.com/apache/cordova-plugin-splashscreen/blob/cd61952efc68365138115cb1d5fbefa0695198d1/src/ios/CDV
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-50960218
When very quickly open and show application, there possibility of the
application crash.
This is caused by following code:
https://github.co
Github user joshbuchea commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-50948393
What's the behavior of the issue this is supposed to fix?
I'm having issues with the plugin not honoring AutoHideSplashScreen in iOS
7.1 &
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21
CB-7204 Fixed race condition when hiding splash
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kant2002/cordova-plugin-spl
28 matches
Mail list logo
