[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-09-06 Thread markv
Github user markv commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj @urmx @tobiasviehweger can we get this PR merged? Thanks --- - To unsubscribe, e-mail:

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-25 Thread hollyschinsky
Github user hollyschinsky commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj @urmx @tobiasviehweger It's a bit confusing with iOS because the status bar styling has changed several times and the `blacktranslucent` and `blackopaque` were

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-25 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Excellent, thanks for signing the ICLA! Ping @hollyschinsky - can you check what @urmx and @tobiasviehweger mention here with respect to the blacktranslucent/blackopaque bits

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-25 Thread urmx
Github user urmx commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @tobiasviehweger For the blacktranslucent behavior, I used this [plugin README](https://github.com/apache/cordova-plugin-statusbar/blob/master/README.md#statusbarstyleblacktranslucent):

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-25 Thread urmx
Github user urmx commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj Yes, I also did 3 days ago. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-25 Thread tobiasviehweger
Github user tobiasviehweger commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj @urmx We probably should also check about the blacktranslucent one. It seems we implemented that differently, but I din't quite remember why.. Also we have other

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-24 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Cool, so we can fall back on your PR should @urmx be unable to. What about you, @urmx ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-24 Thread tobiasviehweger
Github user tobiasviehweger commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj I did, actually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-24 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Two PRs for the same feature, wow! Thanks you two. Have either of you signed an ICLA? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Cordova CI Build has completed successfully. **Commit** -