Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117386712
Code does work. I have been running my plugin tests with this change.
For the Cordova mobile spec, I don't have an iOS device on me
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117366652
Also, Marcus have you filed the Apache iCLA? If not please sign, scan and
send one to secret...@apache.org: http://www.apache.org/licenses/icla.tx
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117333658
Due to some bugs with iOS, I'm unable to test this after the rebase on my
machine. @marcuspridham have you verified that the code works?
---
If
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117282507
Ok, LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117172177
Just updating the Jasmine files. No custom changes.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116949803
I've tested on iOS and it seems to work fine. @marcuspridham, did you make
any custom changes, or is it just an update of the files that belong to
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116850705
On it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116774679
@dblotsky Can you take a look at this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
GitHub user marcuspridham opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/13
CB-9071 Update test framework plugin to use Jasmine 2.3.4
Updating Jasmine version from 2.2.0 to 2.3.4.
You can merge this pull request into a Git repository by running:
