[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-05-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-219856568 This isn't a regression, and this PR has been open for quite a while so I'm going to merge this. That being said, I will create a JIRA because we can

[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-05-17 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-219847832 @stewshka the `cordovaDependencies` object is used by Cordova, not npm, so it isn't really covered in the npm docs. You can find our documentation on

[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-05-12 Thread stewshka
Github user stewshka commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-218947372 My visual studio complains that the "engines" item must have an object as its value. But when I paste your code, i get a complain that the

[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-03-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/18 CB-10866: Adding engine info to package.json Putting the version constraint at 0.0.0 because the whitelist used to be part of the platform You can merge this pull request into a