Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/143#issuecomment-176045173
I've created [CB-10463](https://issues.apache.org/jira/browse/CB-10463) for
appxmanifest improvements
---
If your project is set up for it, you can
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/143#issuecomment-175908924
I'm OK if we want to fix this tactically right now and take a work item
shortly after to fix this correctly.
---
If your project is set up for it, you can
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/143#issuecomment-175617770
@nikhilkh, it seems there is another, more general way to resolve this. We
might reuse the same caching facility as used by `ConfigChanges` module.
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/143
CB-10394 Do not cache manifest file while getting package name
This fixes [CB-10394](https://issues.apache.org/jira/browse/CB-10394)
You can merge this pull request into a Git
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/143#issuecomment-175166044
This design seems to be problematic - From what I understand, there are
multiple places where we could be reading and writing a manifest. One of them
caches
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/143#issuecomment-175167399
The fix seems correct and fixes the current symptom - I'm concerned that
there are other ways/it's easy to make similar mistakes in the future.
---
If your
